Skip to content

Conversation

@haydenbaker
Copy link
Contributor

@haydenbaker haydenbaker commented Feb 20, 2025

Description of changes:

  • Changes the codegen package structure, adds buildSrc plugins to clean up gradle configs
    • New packages will be easy to add with these changes
    • Removed aws package since it was effectively empty, can be re-added later
    • codegen-test package moved into the integration tests of core
  • Adds spotless, formatted codegen
  • Annotated all classes not labeled unstable as internal
  • Adds instructions for setting up virtualenv with pants to ease development
  • Updates Makefile to correctly display help info
Usage:
  make <target>

Targets:
  help                       Show this help.
  ...
  check-py                   Runs checkers for the python packages.
  ...
  clean                      Clean up generated code and artifacts.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@haydenbaker haydenbaker force-pushed the haydenbaker/reorg-structure branch from 8c3aec5 to 9c7ba70 Compare February 20, 2025 18:24
@haydenbaker haydenbaker force-pushed the haydenbaker/reorg-structure branch from 9c7ba70 to 141e475 Compare February 20, 2025 18:27
@haydenbaker haydenbaker marked this pull request as ready for review February 21, 2025 16:25
@haydenbaker haydenbaker requested a review from a team as a code owner February 21, 2025 16:25
@haydenbaker haydenbaker force-pushed the haydenbaker/reorg-structure branch from 71c6fde to cff5f59 Compare February 25, 2025 00:34
Copy link
Contributor

@JordonPhillips JordonPhillips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be rebased, but looks great! Thanks for doing this

@JordonPhillips JordonPhillips merged commit 1a83ad2 into develop Feb 25, 2025
1 check passed
@nateprewitt nateprewitt deleted the haydenbaker/reorg-structure branch March 10, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants